Skip to content

Update health-metrics-pull-request to skip execution on Dependabot PRs #8158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

DellaBitta
Copy link
Contributor

Discussion

PRs created by Dependabot do not have privledges to run our non-critical Health Check CI workflows. Currently these workflows error-out on all Dependabot changes. It would be a better developer experience if these steps were simply skipped, so it doesn't look like we're merging a PR with errors.

Testing

CI in the feature branch.
Also CI in a Dependabot branch.

API Changes

N/A

Copy link

changeset-bot bot commented Apr 12, 2024

⚠️ No Changeset found

Latest commit: 997b528

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DellaBitta DellaBitta marked this pull request as ready for review April 12, 2024 18:48
@DellaBitta DellaBitta requested a review from a team as a code owner April 12, 2024 18:48
@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@DellaBitta DellaBitta changed the title Update health-metrics-pull-request.yml Update health-metrics-pull-request to skip execution on Dependabot PRs Apr 12, 2024
@DellaBitta DellaBitta merged commit be59b95 into master Apr 12, 2024
35 of 36 checks passed
@DellaBitta DellaBitta deleted the ddb-skip-healthchecks-from-dependabot branch April 12, 2024 21:23
@firebase firebase locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants